Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make quads rectangular (currently square) #14

Open
jatentaki opened this issue Aug 30, 2023 · 0 comments
Open

Make quads rectangular (currently square) #14

jatentaki opened this issue Aug 30, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jatentaki
Copy link
Collaborator

The current vertex shader computes the radius = max(gaussian_sigma_x, gaussian_sigma_y) and then draws square quads of size (radius, radius). It is up to the fragment shader to actually draw them as thin/wide, depending on the vertex data. Drawing the quads in shape (sigma_x, sigma_y) would be significantly more efficient for non-square splats (saves a lot of fragment shader invocations) but requires readjusting some vertex shader code as well.

@jatentaki jatentaki added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant