Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code versions and paper do not match #1

Open
shapovalov opened this issue Feb 7, 2020 · 0 comments
Open

Code versions and paper do not match #1

shapovalov opened this issue Feb 7, 2020 · 0 comments

Comments

@shapovalov
Copy link

Hello, thanks for sharing the code!
Can anyone tell what should be considered source of truth? I have found a few differences between the paper and both versions of the code, e.g.:

  1. initialisation of control points: in C++ and in the paper, PCA on X_world is used, while in Matlab it is just a unit simplex;
  2. as a second step, the paper considers four options depending on the dimensionality of the null space; C++ only has three options (I have not figured out whether N=1 or N=4 missing); in Matlab, for N=1, the algorithm is not matching the pairwise distances between the control points but rather distances to the centre.

I want to open source a PyTorch version but don’t want to implement and benchmark all versions, sou would be good to know which is the source of truth. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant