Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StateLog and Trader should be stateless #288

Open
chanhosuh opened this issue Dec 6, 2023 · 0 comments
Open

StateLog and Trader should be stateless #288

chanhosuh opened this issue Dec 6, 2023 · 0 comments
Assignees
@allt0ld
Labels
priority: medium tech debt Shoulda, coulda, but didn't
Milestone
Simulation Redesign

Comments

@chanhosuh
Copy link
Member

Right now, StateLog and Trader instances have a pool attribute that may get mutated from elsewhere. There is no need for state however, so their methods should be updated with a pool arg instead.
@chanhosuh chanhosuh added priority: medium tech debt Shoulda, coulda, but didn't labels Dec 14, 2023
@chanhosuh chanhosuh added this to the Simulation Redesign milestone Dec 14, 2023
@allt0ld allt0ld self-assigned this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allt0ld allt0ld

Labels
priority: medium tech debt Shoulda, coulda, but didn't
Projects
None yet
Milestone
Simulation Redesign
Development

No branches or pull requests
2 participants
@chanhosuh @allt0ld