Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutation bugs in metrics.state_log.pool_state #273

Closed
allt0ld opened this issue Oct 11, 2023 · 0 comments · Fixed by #274
Closed

Mutation bugs in metrics.state_log.pool_state #273

allt0ld opened this issue Oct 11, 2023 · 0 comments · Fixed by #274
Assignees
@allt0ld
Labels
needs triage
Milestone
0.5.5

Comments

@allt0ld
Copy link
Collaborator

allt0ld commented Oct 11, 2023

The functions in metrics.state_log.pool_state should copy() new references to pool objects like pool.balances to avoid mutation bugs.
@allt0ld allt0ld added this to the 0.5.5 milestone Oct 11, 2023
@allt0ld allt0ld self-assigned this Oct 11, 2023
@allt0ld allt0ld mentioned this issue Oct 11, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allt0ld allt0ld

Labels
needs triage
Projects
None yet
Milestone
0.5.5
Development

Successfully merging a pull request may close this issue.

Mutation bugs in metrics.state_log.pool_state curveresearch/curvesim
1 participant
@allt0ld