Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize pool values from vyper contract storage during tests #254

Open
allt0ld opened this issue Sep 14, 2023 · 0 comments · May be fixed by #260
Open

Initialize pool values from vyper contract storage during tests #254

allt0ld opened this issue Sep 14, 2023 · 0 comments · May be fixed by #260
Labels
priority: low

Comments

@allt0ld
Copy link
Collaborator

allt0ld commented Sep 14, 2023 •
edited
Loading

In test_tricrypto.initialize_pool, some variables such as A and gamma aren't loaded directly from the vyper_tricrypto fixture's storage. We call functions that may return values different from what's in the storage state (the packed variables).

Not a problem right now, but we should fix this if, for example, we do future tests involving ramping A or gamma.

Variables needing a fix:

  • A
  • gamma
@allt0ld allt0ld linked a pull request Sep 15, 2023 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load A and gamma from fixture storage curveresearch/curvesim
1 participant
@allt0ld