Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this package meant as drop-in-replacement of nicolaslopezj:apollo-accounts? #5

Open
smeijer opened this issue Oct 10, 2018 · 1 comment

Comments

@smeijer
Copy link

smeijer commented Oct 10, 2018

The readme still refers to meteor/nicolaslopezj:apollo-accounts, implying that this package is meant as a drop-in replacement of the before mentioned.

import { makeExecutableSchema } from 'graphql-tools';
import { initAccounts } from 'meteor/nicolaslopezj:apollo-accounts';
import { load, getSchema } from 'graphql-load';

Unfortunately, it turned out to be not.

"Unknown type \"HashedPassword\".", ...
"message": "Unknown type \"CreateUserProfileInput\". Did you mean ...
"message": "Cannot query field \"createUser\" on type \"Mutation\". Did you mean ...

Would be nice if the README could be updated, and made the goals of this package, and differences in relation to meteor/nicolaslopezj:apollo-accounts, clear.

@ujwal-setlur
Copy link
Contributor

It started off that way, but was adapted slightly. Some other bugs got fixed, and phone login support was added. So pretty much a separate package. Agree docs should be clear on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants