From 8b0952d98eab233b9f40c3fa95cc4b290206cf05 Mon Sep 17 00:00:00 2001 From: Marcel van Lohuizen Date: Fri, 27 Dec 2024 18:59:14 +0100 Subject: [PATCH] internal/core/adt: remove todo This fix was done before. Removed the corresponding todos. Signed-off-by: Marcel van Lohuizen Change-Id: I79de4a54f578346b1194aff8a6662be323a98d5a Dispatch-Trailer: {"type":"trybot","CL":1206386,"patchset":1,"ref":"refs/changes/86/1206386/1","targetBranch":"master"} --- cue/testdata/eval/v0.7.txtar | 2 -- internal/core/adt/cycle.go | 2 -- 2 files changed, 4 deletions(-) diff --git a/cue/testdata/eval/v0.7.txtar b/cue/testdata/eval/v0.7.txtar index 7c13ba67e..0bea66197 100644 --- a/cue/testdata/eval/v0.7.txtar +++ b/cue/testdata/eval/v0.7.txtar @@ -1566,8 +1566,6 @@ diff old new } -- diff/explanation -- Bug fixes --- diff/todo/p0 -- -mutual.t4.p1: dropped fields. See comment in cycle.go that references this bug. -- diff/todo/p2 -- Reordering / positions. -- out/compile -- diff --git a/internal/core/adt/cycle.go b/internal/core/adt/cycle.go index d05deed1a..ceead7535 100644 --- a/internal/core/adt/cycle.go +++ b/internal/core/adt/cycle.go @@ -650,8 +650,6 @@ func (n *nodeContext) detectCycleV3(arc *Vertex, env *Environment, x Resolver, c if equalDeref(r.Node, n.node) { // reference cycle - // TODO: in some cases we must continue to fully evaluate. - // Return false here to solve v0.7.txtar:mutual.t4.ok.p1 issue. return ci, true }