From 82ebb119173fc0fd4f946147a2a6800630fae2e0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Tue, 24 Dec 2024 15:34:59 +0000
Subject: [PATCH] cmd/cue: test whether tidy can add a dependency path with
 dashes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

It currently cannot, as reported by a user trying modules for the first
time and running into some rather confusing errors.

It's correct for loading a package to fail if a qualifier is necessary
and the user did not provide it, but `cue mod tidy` does not need
to load packages, and it shouldn't fail where `cue mod get` works.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: I53b1d773741db9285b9173ac5502eb7c9dddc7ca
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1206331
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Paul Jolly <paul@myitcv.io>
---
 .../testdata/script/module_path_dash.txtar    | 111 ++++++++++++++++++
 1 file changed, 111 insertions(+)
 create mode 100644 cmd/cue/cmd/testdata/script/module_path_dash.txtar

diff --git a/cmd/cue/cmd/testdata/script/module_path_dash.txtar b/cmd/cue/cmd/testdata/script/module_path_dash.txtar
new file mode 100644
index 000000000..4e08bfa5d
--- /dev/null
+++ b/cmd/cue/cmd/testdata/script/module_path_dash.txtar
@@ -0,0 +1,111 @@
+# Test that it's possible to publish, depend on, and import a module
+# whose path ends with a name containing a dash like foo-bar.
+# Note that foo-bar is not a valid package name, but is allowed in a module path.
+# Note that this is similar to pkg_resolution_path_element_invalid_ident.txtar,
+# but this concerns module paths and publishing/retrieving them.
+
+memregistry MEMREGISTRY
+env CUE_REGISTRY=$MEMREGISTRY
+
+cd publisher
+exec cue mod publish v1.0.0
+cd ..
+
+# First, see what happens if the user forgot to qualify the CUE package import.
+# mod tidy should work, because it is able to locate a module containing a package
+# at the given import path, but export should fail, as no explicit package is named.
+cd importer-noqualifier
+# TODO(mvdan): tidy should work here.
+! exec cue mod tidy
+cmp stderr tidy.stderr
+cmp cue.mod/module.cue cue.mod/module.cue.want
+! exec cue export .
+cmp stderr export.stderr
+cd ..
+
+# Similarly, "getting" the entire module should work, even if no valid package name
+# can be derived from the module path.
+cd getter-noqualifier
+exec cue mod get main.org/foo-bar
+cmp cue.mod/module.cue cue.mod/module.cue.want
+cd ..
+
+# With an explicit qualifier, both mod tidy and export work just fine.
+cd importer-withqualifier
+exec cue mod tidy
+cmp cue.mod/module.cue cue.mod/module.cue.want
+exec cue export .
+cmp stdout export.stdout
+cd ..
+
+-- importer-noqualifier/cue.mod/module.cue --
+module: "main.org/importer-noqualifier@v1"
+language: {
+	version: "v0.9.0"
+}
+-- importer-noqualifier/cue.mod/module.cue.want --
+module: "main.org/importer-noqualifier@v1"
+language: {
+	version: "v0.9.0"
+}
+-- importer-noqualifier/main.cue --
+package importer
+
+import "main.org/foo-bar@v1"
+
+foobar.contents
+-- importer-noqualifier/tidy.stderr --
+failed to resolve "main.org/foo-bar@v1": cannot determine package name from import path "main.org/foo-bar@v1"
+-- importer-noqualifier/export.stderr --
+main.org/importer-noqualifier@v1: import failed: cannot determine package name for "main.org/foo-bar@v1"; set it explicitly with ':':
+    ./main.cue:3:8
+-- getter-noqualifier/cue.mod/module.cue --
+module: "main.org/getter-noqualifier@v1"
+language: {
+	version: "v0.9.0"
+}
+-- getter-noqualifier/cue.mod/module.cue.want --
+module: "main.org/getter-noqualifier@v1"
+language: {
+	version: "v0.9.0"
+}
+deps: {
+	"main.org/foo-bar@v1": {
+		v: "v1.0.0"
+	}
+}
+-- importer-withqualifier/cue.mod/module.cue --
+module: "main.org/importer-withqualifier@v1"
+language: {
+	version: "v0.9.0"
+}
+-- importer-withqualifier/cue.mod/module.cue.want --
+module: "main.org/importer-withqualifier@v1"
+language: {
+	version: "v0.9.0"
+}
+deps: {
+	"main.org/foo-bar@v1": {
+		v: "v1.0.0"
+	}
+}
+-- importer-withqualifier/main.cue --
+package importer
+
+import "main.org/foo-bar@v1:foobar"
+
+foobar.contents
+-- importer-withqualifier/export.stdout --
+"source for foo-bar"
+-- publisher/cue.mod/module.cue --
+module: "main.org/foo-bar@v1"
+language: {
+	version: "v0.9.0"
+}
+source: {
+	kind: "self"
+}
+-- publisher/main.cue --
+package foobar
+
+contents: "source for foo-bar"