From 480235f32d32fca3288b4394f5b56fb101c556f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Tue, 10 Sep 2024 18:26:49 +0100 Subject: [PATCH] internal: remove MaxDepth MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Unused since 2020, since the evaluator now does have cycle detection. Signed-off-by: Daniel Martí Change-Id: I80f43267f68848c6ad014d2be1a7d17312e42eee Dispatch-Trailer: {"type":"trybot","CL":1200972,"patchset":3,"ref":"refs/changes/72/1200972/3","targetBranch":"master"} --- internal/internal.go | 9 --------- 1 file changed, 9 deletions(-) diff --git a/internal/internal.go b/internal/internal.go index e8b377322..60011807c 100644 --- a/internal/internal.go +++ b/internal/internal.go @@ -446,12 +446,3 @@ type decorated struct { func (e *decorated) Is(err error) bool { return errors.Is(e.info, err) || errors.Is(e.cueError, err) } - -// MaxDepth indicates the maximum evaluation depth. This is there to break -// cycles in the absence of cycle detection. -// -// It is registered in a central place to make it easy to find all spots where -// cycles are broken in this brute-force manner. -// -// TODO(eval): have cycle detection. -const MaxDepth = 20