Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting authentication through a managed identity instead of using a normal app #3

Open
Epoxylim opened this issue Apr 25, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request roadmap To implement in a future release

Comments

@Epoxylim
Copy link

Would this be something that could be supported going forward?

@cudeso cudeso added the enhancement New feature or request label May 5, 2023
@cudeso
Copy link
Owner

cudeso commented May 6, 2023

Yes, it's certainly something to consider.
I do not have a lot of experience with authenticating via a managed identity but I'll put it on the list to investigate and for future implementations.

@cudeso cudeso added the roadmap To implement in a future release label May 6, 2023
@cudeso cudeso self-assigned this Jul 20, 2023
@lnfernux
Copy link
Collaborator

I can probably do this for the azure function app already, it's pretty simple to integrate a authentication chain there. I'll do a PoC and push it as a PR once the upload indicators branch is merged.

Should be the same lines of code for a vm running in Azure as it is for the Azure Function :)

@Kaloszer
Copy link
Contributor

Kaloszer commented Oct 4, 2023

Hey @Infernux, were you able to do that yet? I actually really really want to do it that way :D

@lnfernux
Copy link
Collaborator

lnfernux commented Oct 9, 2023

I have a PoC for this locally, but I haven't made it production friendly yet. Will try to get some time to do that the following weeks, I'll update here once I'm able.

@jusso-dev
Copy link
Contributor

jusso-dev commented Feb 18, 2024

I noticed that the README mentions Azure Key Vault (only works on Azure VM) - "https://github.com/cudeso/misp2sentinel/tree/main?tab=readme-ov-file#azure-key-vault-integration-only-works-on-azure-vms"

But I'm not sure why this is called out? If the Azure Function has SystemIdentity/Managed System Identity (MSI) turned on, there is no reason it won't work with Azure Key Vault, you just need to configure the provisioned MSI with relevant Azure Key Vault RBAC or Access Policies.

@lnfernux
Copy link
Collaborator

lnfernux commented Mar 5, 2024

@jusso-dev Because the Azure Function uses MSI to call KV as well, but does this outside of the code (integration via Application Settings, where you can do a key vault reference). This is just an easier integration, without having to write any code to do it. The outcome is the same :)

@jusso-dev
Copy link
Contributor

Clarified in #86
@lnfernux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request roadmap To implement in a future release
Projects
None yet
Development

No branches or pull requests

5 participants