Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong quickstart example in the book #200

Closed
mladedav opened this issue Jan 28, 2022 · 2 comments
Closed

Wrong quickstart example in the book #200

mladedav opened this issue Jan 28, 2022 · 2 comments
Assignees
Labels
enhancement Improvement of existing features or bugfix k::documentation Related to project documentation
Milestone

Comments

@mladedav
Copy link

The quickstart uses this function to start the example (only the path is important here):

    futures::executor::block_on(AnimalWorld::run("/tests/features/book"));

Then when this is converted to tokio at the end of the quickstart, that path also has a leading slash.

This does not work for me with cucumber saying Failed to parse: Failed to parse feature: Could not read path: /tests/features/book, however when the leading slash is deleted everything works as expected.

I wanted to check first whether this should work (and maybe does not because of my system?) or the leading slashes should be rdeleted.

I am running rust 1.58 on Windows 10, cucumber 0.11.2.

@ilslv
Copy link
Member

ilslv commented Jan 31, 2022

@mladedav

I am running rust 1.58 on Windows 10

Yeah, thats makes sense, because afaik all current maintainers are using macOS or Linux. If thats ok for you, I'll happily review your PR fixing this and maybe also adding windows target to the test-book CI job.

@ilslv ilslv added enhancement Improvement of existing features or bugfix k::documentation Related to project documentation labels Jan 31, 2022
@tyranron tyranron assigned ilslv and unassigned mladedav Jan 31, 2022
tyranron pushed a commit that referenced this issue Feb 2, 2022
@tyranron
Copy link
Member

This has been fixed in #202 and now is tested on CI.

@tyranron tyranron added this to the 0.12.0 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::documentation Related to project documentation
Projects
None yet
Development

No branches or pull requests

3 participants