Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this a WCA-approved scramble? #9

Open
zaynv opened this issue Jul 28, 2016 · 6 comments
Open

Is this a WCA-approved scramble? #9

zaynv opened this issue Jul 28, 2016 · 6 comments

Comments

@zaynv
Copy link

zaynv commented Jul 28, 2016

If I do:

scramblers["333"].getRandomScramble().scramble_string

Will the scramble_string be a "random-state scramble" like they use at WCA? Thanks!

@coder13
Copy link
Member

coder13 commented Dec 20, 2016

Yes

@zaynv
Copy link
Author

zaynv commented Dec 27, 2016

Thanks! Would you consider publishing this module to npm? Something like:

var scrambler = require('scramblersuite')['333'];
scrambler.getRandomScramble().scramble_string;

@coder13
Copy link
Member

coder13 commented Dec 27, 2016

something similar already exists on npm. https://www.npmjs.com/package/scrambo is (should be) a direct, unofficial port of jsss to node.

Although to minimize repos to work on, I wonder if @lgarron might want this repo turned into a npm package to be published to npm?

@saadq
Copy link

saadq commented Jul 3, 2017

It would be great if you guys would be willing to do that. You kind of lose out on some functionality if you use the scrambo package. For example, it doesn't allow you to use drawScramble(). I opened an issue there awhile back, but I'm not sure if he's still actively maintaining it. I was considering just forking his and creating another npm package that kept all the features, but if you guys would be interested in publishing an official version that would definitely be better.

@lgarron
Copy link
Member

lgarron commented Jul 4, 2017

I'm unlikely to do this with jsss, because the code is messy and licensing is... not clear.

I'm planning to make a better alternative some day, but it's low-priority for me.

@saadq
Copy link

saadq commented Jul 8, 2017

Thanks for the reply, I guess for now I'll just create another unofficial npm package that retains the drawScramble functionality if that's okay with you guys.


Edit: Created scramby awhile back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants