Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cubing.js issue] Scale of experimental-2D-LL sides stickers is inconsistent between cubes #319

Open
Jobarion opened this issue Feb 2, 2024 · 2 comments

Comments

@Jobarion
Copy link

Jobarion commented Feb 2, 2024

Steps to reproduce the issue

Configuring a TwistyPlayer with visualization="experimental-2D-LL" and a puzzle="2x2x2" or puzzle="4x4x4" produces an output that is technically correct, but the scale of the side facelets seems overly large compared to the upper facelets.

Observed behaviour

See above

🖼 Screenshots

Correct scale for 3x3x3
image
Wrong scales for 2x2x2 and 4x4x4
image
image

Expected behaviour

I expected relative size difference between the side, and the upper facelets to be similar for 2x2x2, 3x3x3 and 4x4x4.

Environment

https://experiments.cubing.net/cubing.js/twisty/twisty-player-config.html, on Firefox and Chrome

Additional info

No response

@Jobarion Jobarion added the 🐞 bug Something isn't working label Feb 2, 2024
@lgarron
Copy link
Member

lgarron commented Feb 3, 2024

This is by design, so that every sticker in a given image is roughly the same size. The sides for 3x3x3 should probably be a little bit larger.

@lgarron lgarron added 📦 cubing/twisty and removed 🐞 bug Something isn't working labels Feb 3, 2024
@Jobarion
Copy link
Author

Jobarion commented Feb 3, 2024

I believe the relative scale of 3x3x3 looks best, the other two are a little bit disorienting in my opinion. But that's a design decision that's obviously up to you. Either way, all of them should probably be similar.

@lgarron lgarron changed the title [cubing.js issue] Scale of experimental-2D-LL side facelets is incorrect for some puzzles [cubing.js issue] Scale of experimental-2D-LL sides stickers is inconsistent between cubes Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants