Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up write back method names #966

Open
rclapp opened this issue Sep 12, 2023 · 3 comments
Open

Clean up write back method names #966

rclapp opened this issue Sep 12, 2023 · 3 comments
Milestone

Comments

@rclapp
Copy link
Collaborator

rclapp commented Sep 12, 2023

TM1py methods like write_dataframe_async and write_async names are confusing and misleading. These methods parallelize write back operations, and don't expose async write operations.

https://github.com/cubewise-code/tm1py/blob/master/TM1py/Services/CellService.py#L758
https://github.com/cubewise-code/tm1py/blob/master/TM1py/Services/CellService.py#L690

Instead, they should be named something like write_dataframe_chunked or write_dataframe_parallel.

@MariusWirtz
Copy link
Collaborator

Agree.
I like write_dataframe_parallel.

@MariusWirtz
Copy link
Collaborator

An alternative solution here would be to expose the optional parallelization to the normal functions through additional arguments like max_workers as was done in #1030 on execute_mdx, execute_view.

This approach has proven beneficial in the implementation as it allows for efficient recycling of the existing test cases without code duplication.

@MariusWirtz MariusWirtz added this to the 2.1 milestone Jan 23, 2024
@rclapp
Copy link
Collaborator Author

rclapp commented Jan 23, 2024

I agree I think the more we standardize the better. I like that option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants