Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add only repos with Info.lua file #39

Open
madmaxoft opened this issue Aug 21, 2016 · 7 comments
Open

Add only repos with Info.lua file #39

madmaxoft opened this issue Aug 21, 2016 · 7 comments

Comments

@madmaxoft
Copy link
Member

The "Add plugin" page should filter out all repos that don't have an Info.lua file - those are likely not Cuberite plugins (and we want to encourage plugins to use an Info file as much as possible)

@tigerw
Copy link
Member

tigerw commented Aug 21, 2016

You sure about this? Quite a few don't have them.

@NiLSPACE
Copy link
Member

Currently the ones which do not have an Info.lua are old. And if not they can be easily changed to include an Info.lua

We could also do this in steps. At first don't show anything without an Info.lua or press a button that will show every owned repo.

Personally I think we should as @madmaxoft wants filter out everything. That will really encourage developers to use the Info.lua

@madmaxoft
Copy link
Member Author

At the very least, we should split the repos into those that have the file and display those above all the rest, with a divider saying "The following repos are unlikely to be Cuberite plugins".

@sphinxc0re
Copy link

I really dislike all the capitalization. Should we really force the devs to name the file exactly that way?

@madmaxoft
Copy link
Member Author

It's just like GitHub forcing people to use README.md

@sphinxc0re
Copy link

Yeah, but we can do better. Either ALL CAPS or all lowercase.

@tigerw
Copy link
Member

tigerw commented Aug 22, 2016

I prefer filenames to be written as my English teachers would approve. That includes proper spacing and capitalisation of names.

I feel that programmers should be made aware that "lib" and "src" for example, should not be considered alternatives for "Libraries" and "Source Files", but maybe I'm just not unix-y enough :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants