Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional c++11 VS c++11 requirement of libxml++ #2

Open
tschiemer opened this issue Jul 18, 2019 · 2 comments
Open

optional c++11 VS c++11 requirement of libxml++ #2

tschiemer opened this issue Jul 18, 2019 · 2 comments

Comments

@tschiemer
Copy link
Contributor

As (at least newer versions of) libxml++ follow the c++11 standard builds where this is not c++11 compliance is not enabled by default will fail.

It might be worth a consideration to enable --force-cpp11 by default to avoid this error case.

@cth103
Copy link
Owner

cth103 commented Jul 19, 2019

Perhaps, yes. I guess the default should be right for the majority. I'm not sure whether the majority are using a new enough libxml++ though...

@tschiemer
Copy link
Contributor Author

Well, I would go for the way where builds break with the least probability.

That is, if it doesn't hurt (break) to have c++11 enabled by default, then I would enable it and add the option to disable it instead.
->ie the question: does your typical compiler support c++11 or are there other components breaking with it?

Otherwise I'd leave it as is, but add a comment in the readme (or a version check in the build system)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants