Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Python 3 compatible #24

Open
csu opened this issue Dec 22, 2014 · 9 comments
Open

Make Python 3 compatible #24

csu opened this issue Dec 22, 2014 · 9 comments

Comments

@csu
Copy link
Owner

csu commented Dec 22, 2014

Aiming for Python 2.6+ and Python 3.3+ compatibility.

@csu
Copy link
Owner Author

csu commented Dec 22, 2014

I started a Python 3 branch that I will begin work in. Feel free to fork and request into it.

@rohithpr
Copy link
Contributor

How about leaving python 2 behind and making python 3 branch as the master branch?

@csu
Copy link
Owner Author

csu commented Dec 24, 2014

We should be able to write code that is both Python 2 and Python 3 compatible. That work is happening in the python3 branch right now, and when it's working, we'll merge it into master.

On Wed, Dec 24, 2014 at 4:36 PM, Rohith PR [email protected]
wrote:

How about leaving python 2 behind and making python 3 branch as the master branch?

Reply to this email directly or view it on GitHub:
#24 (comment)

@rohithpr
Copy link
Contributor

Oh, okay.

@svisser
Copy link
Contributor

svisser commented Jan 1, 2015

Have you considered keeping one branch and incrementally working towards 2.x and 3.x support? This seems an easier approach than branching-off to support Python 3 and then merging it back in. With adequate testing (such as by using tox) every commit should preserve functionality in the same codebase and work towards a 2.x/3.x-compatible codebase.

@csu
Copy link
Owner Author

csu commented Jan 1, 2015

The python3 branch is intended to be both Pyrhon 2 and 3 compatible.

On Thu, Jan 1, 2015 at 11:01 PM, Simeon Visser [email protected]
wrote:

Have you considered keeping one branch and incrementally working towards 2.x and 3.x support? This seems an easier approach than branching-off to support Python 3 and then merging it back in. With adequate testing (such as by using tox) every commit should preserve functionality in the same codebase and work towards a 2.x/3.x-compatible codebase.

Reply to this email directly or view it on GitHub:
#24 (comment)

@edwinksl
Copy link

How is the Python 3 branch coming along?

@csu
Copy link
Owner Author

csu commented Jan 23, 2016

Don't think it got very far. You can pick it up, if you want to.

On Jan 22, 2016, 8:54 PM, at 8:54 PM, Edwin Khoo [email protected] wrote:

How is the Python 3 branch coming along?


Reply to this email directly or view it on GitHub:
#24 (comment)

@edwinksl
Copy link

Cool, let me take a look. I am curious if this library violates Quora's TOS since it is basically scraping its web pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants