Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 8 & 4.2/4.3 doesn't seem to work/format #620

Open
lhtdesignde opened this issue Oct 9, 2019 · 0 comments
Open

Node 8 & 4.2/4.3 doesn't seem to work/format #620

lhtdesignde opened this issue Oct 9, 2019 · 0 comments

Comments

@lhtdesignde
Copy link

Hi, I just updated to node 8.16.1 from 6.4.0. I'm on csscomb version 4.2.
When running it seem to execute but when running it verbose it actually shows that it's not writing the files. It does in fact sort them but not write them to the system.

node 8.16.1 + csscomb 4.2:

Reading app/assets/stylesheets/styles.scss...OK
>> Sorting file "app/assets/stylesheets/styles.scss"...
Done.

When downgrading again to node 6 it starts to work again and tells me:
node 6.4.0 + csscomb 4.2:

Reading app/assets/stylesheets/styles.scss...OK
>> Sorting file "app/assets/stylesheets/styles.scss"...
Writing app/assets/stylesheets/styles.scss...OK
Done.

And in fact it formats my files in node version 6 but not in 8. Downgrading to csscomb v3.1 also fixes the issue.
node 8.16.1 + csscomb 3.1.8:

Reading app/assets/stylesheets/styles.scss...OK
>> Sorting file "app/assets/stylesheets/styles.scss"...
Writing app/assets/stylesheets/styles.scss...OK
Done.

So not sure why this is, but at least you got a good idea what to be aware of when using more node 8 features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant