Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in setter ac.fan_step0 / ac.fan_step1 / ac.fan_step2 / ac.fan_step3 in config file wolf-cwl-configuration.json #17

Open
LuiSauberhorn opened this issue Aug 20, 2023 · 0 comments

Comments

@LuiSauberhorn
Copy link

Bug in setter for CWL300/400

Hi @csowada,

I tested your new binding, works well.

However, as you may remember, I was the one sending you the config for the CWL400. In context of changing the binding, I also changed to your config file. In general works fine, but there is one bug/typo.

In https://github.com/csowada/ebus-configuration/blob/master/src/main/resources/commands/wolf-cwl-configuration.json, we have the following code for ac.fan_step0, ac.fan_step1, ac.fan_step2, and ac.fan_step3:

        {   
            "label":    "Fan Step X",
            "id":       "ac.fan_stepX",

            "get": {
                "command": "40 50",
                "master": [
                    {"type": "static", "default": "03"}
                ],
                "slave": [
                    {"name": "fan_stepX", "type": "uint", "label":"Current Value", "reverseByteOrder": true, "format":"%4dm³/h"},   
                    {"name": "min", "type": "uint", "label":"Minimum", "reverseByteOrder": true, "format":"%4dm³/h"},   
                    {"name": "max", "type": "uint", "label":"Maximum", "reverseByteOrder": true, "format":"%4dm³/h"},   
                    {"name": "step", "type": "uint", "label":"Step", "reverseByteOrder": true, "format":"%4dm³/h"},   
                    {"name": "factory_default", "type": "uint", "label":"Factory Default", "reverseByteOrder": true, "format":"%4dm³/h"}
               ]
            },

            "set": {
                "command": "40 80",
                "master": [
                    {"type": "static", "default": "03"},
                    {"name": "cur", "type": "uint", "label":"Current Value", "reverseByteOrder": true, "min": 50, "max": 400, "step": 5, "format":"%4dm³/h"}   
                ]
            }
        },

The setter still uses my old name cur instead of the one you set fan_stepX. By that, I can read but not write. As far as I can see, that only affects the steps.

Lüftungsanlage CWL 400 Excellent

Leave out the rest, as the problem should be obvious. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant