Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64 instruction decoding code depends on system headers #1

Open
tzussman opened this issue May 3, 2023 · 0 comments
Open

arm64 instruction decoding code depends on system headers #1

tzussman opened this issue May 3, 2023 · 0 comments

Comments

@tzussman
Copy link
Member

tzussman commented May 3, 2023

For x86, kedr stole the kernel’s x86 instruction decoding code, along with various header and support files. This was meant to allow kedr to keep working even if the kernel’s instruction decoding API changed (which it has a little bit, since kedr took these files in 2010 and hasn’t updated them since). Kent took arm64’s instruction decoding logic (insn.c), but didn’t take the header files (on x86 there’s only 3-4 files, but on arm64 the header dependencies are a little more intricate so it’s more than that… probably in double digits). This means that kedr will use the system headers, which may have a different API, which caused various issues for kedr back in 2012. Since we’re using the same kernel version as the code for the arm64 instruction decoding that we took (for now), this shouldn’t be a problem (since it clearly works), but it’s not ideal.

It would probably also be a good idea to update the x86 instruction decoding in kedr at some point… there have been a fair amount of improvements + bug fixes since 2010, but it would mean pulling in some new files and potentially messing with some kedr code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant