Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache get_installable_versions and get_available_versions #145

Open
0xalpharush opened this issue Jan 3, 2023 · 3 comments
Open

cache get_installable_versions and get_available_versions #145

0xalpharush opened this issue Jan 3, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@0xalpharush
Copy link
Contributor

There's no need to repeatedly invoke these requests since once the platform is determined, these should not change

@azpwnz
Copy link
Contributor

azpwnz commented Jan 23, 2023

Would love to help to implement this improvement.

@0xalpharush could you please suggest some examples of how caching might be done here? If you have anything on mind :)

@azpwnz
Copy link
Contributor

azpwnz commented Jan 23, 2023

I believe we couldn't cache get_installable_versions() since installed_versions() will be changing.
What do you think?

@0xalpharush
Copy link
Contributor Author

0xalpharush commented Jan 24, 2023

I think we should probably create a class so that there's a way to persist data and update installed_versions. For now, caching get_available_versions is fine as this one involves network requests which we want to reduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants