Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CMS page #146

Merged
merged 11 commits into from
Jan 5, 2024
Merged

Add CMS page #146

merged 11 commits into from
Jan 5, 2024

Conversation

skoriop
Copy link
Member

@skoriop skoriop commented Jan 5, 2024 •
edited
Loading

The main bugs as of now:

  • All sections to enroll in are duplicated (can be fixed)
  • Each course manages to overwrite the existing course list somehow

For example, on page load:
image

But after a few seconds:
image

This probably has something to do with sectionNameList and fetchCourseDetailsQueryOptions().

Edit: fixed in 36ec8ff

@skoriop skoriop marked this pull request as ready for review January 5, 2024 08:53
@skoriop skoriop requested a review from soumitradev January 5, 2024 08:59
soumitradev
soumitradev approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@soumitradev soumitradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumitradev soumitradev added this pull request to the merge queue Jan 5, 2024
Merged via the queue into master with commit b10fad3 Jan 5, 2024
1 check passed
@skoriop skoriop linked an issue Jan 5, 2024 that may be closed by this pull request
Implement CMS functions page #112
Closed
@majimearun majimearun deleted the add-cms-page branch January 21, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumitradev soumitradev soumitradev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement CMS functions page
2 participants
@skoriop @soumitradev