Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret in InitProvider is required but should be optional #456

Open
denniskniep opened this issue Dec 10, 2024 · 0 comments
Open

Secret in InitProvider is required but should be optional #456

denniskniep opened this issue Dec 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@denniskniep
Copy link

The Property IdentityProviderSpec.InitProvider.ClientSecretSecretRef
(see https://github.com/crossplane-contrib/provider-keycloak/blame/11f3432fc6cbf1f12168f6e3ba425f79ad0d5710/apis/oidc/v1alpha1/zz_identityprovider_types.go#L55-L57)

is a required field since updating upjet to to v1.4.0
(see https://github.com/crossplane/upjet/releases/tag/v1.4.0 -> Support for Secret References in spec.initProvider)

InitProvider properties are set if the value of the property should only be taken into account during creation and not during update
(see https://docs.crossplane.io/latest/concepts/managed-resources/#initprovider)

But from Keycloaks point of view the client secret of an OIDC IdentityProvider is NOT immutable.

It should be possible to set ClientSecretSecretRef via forProvider and skip setting it at the initProvider

Additional Notes:
forProvider defines the field "ClientSecretSecretRef" also as required.
Which leads to the situation that I have to specify both (initProvider and forProvider), which might run into the following issue: #299

ref: crossplane-contrib/provider-keycloak#113

@denniskniep denniskniep added the bug Something isn't working label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant