Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Terraform provider version to 2.53.1 #167

Merged

Conversation

erhancagirici
Copy link
Collaborator

@erhancagirici erhancagirici commented Nov 3, 2024

Description of your changes

Updated Terraform provider version to 2.53.1
This PR is recreated from original PR by community, to move forward with changes.

Adjusted the go version to 1.23 and golangci-lint version to 1.61.0 in CI job.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

make reviewable test and uptest

hazim1093 and others added 3 commits November 1, 2024 09:27
Signed-off-by: Hazim <[email protected]>
(cherry picked from commit 0d86fec)
Signed-off-by: Hazim <[email protected]>
Signed-off-by: Erhan Cagirici <[email protected]>
@erhancagirici
Copy link
Collaborator Author

/test-examples="examples/app/v1beta1/roleassignment.yaml"

Signed-off-by: Erhan Cagirici <[email protected]>
@erhancagirici erhancagirici changed the title [wip][backup]Update tf provider 2.53.1 [wip][backup]Update Terraform provider version to 2.53.1 Nov 3, 2024
@turkenf
Copy link
Collaborator

turkenf commented Nov 4, 2024

/test-examples="examples/serviceprincipals/v1beta1/principal.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 4, 2024

/test-examples="examples/applications/v1beta1/application.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 4, 2024

/test-examples="examples/applications/v1beta1/password.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 4, 2024

/test-examples="examples/administrativeunits/v1beta1/unit.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @erhancagirici, LGTM 🙌

@erhancagirici erhancagirici marked this pull request as ready for review November 4, 2024 12:25
@erhancagirici erhancagirici changed the title [wip][backup]Update Terraform provider version to 2.53.1 Update Terraform provider version to 2.53.1 Nov 4, 2024
@erhancagirici erhancagirici merged commit 25c0c9a into crossplane-contrib:main Nov 4, 2024
13 checks passed
@erhancagirici erhancagirici deleted the update-tf-provider-2.53.1 branch November 4, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants