Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for JPMS (java module system) #41

Open
bademux opened this issue Jul 25, 2020 · 4 comments
Open

Please add support for JPMS (java module system) #41

bademux opened this issue Jul 25, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@bademux
Copy link

bademux commented Jul 25, 2020

Introducing module-info.java will hilight dependencies.
For example JVips uses java.awt.Dimension, this forces us to use whole java.desktop module, an it will block from using graalvm to compile app with JPMS to native binary (and also increase size for JLinked app).

@warrenseine
Copy link
Contributor

I’m not familiar with JPMS, but it looks like a Java 9 feature, and JVips supports Java 8, so I doubt we’ll implement it.

@bademux
Copy link
Author

bademux commented Jul 25, 2020

@warrenseine Sorry I missed that. Can be closed then

@bademux bademux closed this as completed Jul 25, 2020
@bademux
Copy link
Author

bademux commented Jul 26, 2020

Upd.
Will it be acceptable to add attribute "Automatic-Module-Name: JVips" to manifest? More info: https://docs.oracle.com/javase/9/docs/specs/jar/jar.html

@bademux bademux reopened this Jul 26, 2020
@warrenseine
Copy link
Contributor

I suppose so, as long as it's ignored in previous Java versions.

@warrenseine warrenseine added the enhancement New feature or request label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants