Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing naming\function Image#imageGetFormat #40

Open
bademux opened this issue Jul 25, 2020 · 1 comment
Open

Confusing naming\function Image#imageGetFormat #40

bademux opened this issue Jul 25, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@bademux
Copy link

bademux commented Jul 25, 2020

I think there is can be problem with VipsBandFormat vs VipsImageFormat especially for Image#imageGetFormat function.
I'm also curious about naming convention: it isn't clean for me why iit is named like imageGetFormat, and not getImageFormat (getBandFormat ?)

VipsBandFormat imageGetFormat();

@dbouron
Copy link
Contributor

dbouron commented Jul 26, 2020

Hello,
I took the original libvips function name, I removed the vips prefix and the underscores. The function names are in came case. This is why it is imageGetFormat().
We could maybe remove the image prefix because this is an VipsImage method.

@warrenseine warrenseine added the enhancement New feature or request label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants