Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for fixing icon flash issue #83

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blossomese
Copy link

Fixes

Fixes #10 by @possumbilities

Description

This PR fixes the issue where logos and social icons flash purple briefly when clicked.
The fix moves the SVG mask to a child pseudo-element to allow the standard focus outline behavior and prevent the purple flash.

Technical details

The solution involves moving the SVG mask to a :before pseudo-element, which allows the main element to have a standard focus outline without the color flash issue. This method ensures that the icon styles are preserved while eliminating the visual glitch.

Tests

  1. Click on any of the social icons.
  2. Verify that the icon no longer flashes purple.
  3. Check that the focus outline is displayed as expected when the icon is clicked.

Checklist

  • My pull request has a descriptive title.
  • My pull request targets the default branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified there are no visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@blossomese blossomese requested review from a team as code owners October 4, 2024 11:11
@blossomese blossomese requested review from TimidRobot, Shafiya-Heena, possumbilities, MuluhGodson and zackkrida and removed request for a team October 4, 2024 11:11
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit 72cc709
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/66ffcd70f151a90008e7d361
😎 Deploy Preview https://deploy-preview-83--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Bug] logos/social icons flash purple briefly on click
1 participant