Initial commit for fixing icon flash issue #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #10 by @possumbilities
Description
This PR fixes the issue where logos and social icons flash purple briefly when clicked.
The fix moves the SVG mask to a child pseudo-element to allow the standard focus outline behavior and prevent the purple flash.
Technical details
The solution involves moving the SVG mask to a
:before
pseudo-element, which allows the main element to have a standard focus outline without the color flash issue. This method ensures that the icon styles are preserved while eliminating the visual glitch.Tests
Checklist
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin