Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change button text when active or inactive. #145

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SisiVero
Copy link
Contributor

@SisiVero SisiVero commented Oct 8, 2024

Fixes

Description

This PR address the issue #89 . Active and Inactive feature was added to blog-index.html View button. This changes the text from "View" to "Close" when it is open and vice versa.

Technical details

No extra class or id was created. The already existed Js Function for the button was updated to includ the feature.

Tests

  1. When a user clicks on the View button and it opens the panel, the text changes from "view" to "close", thereby enhancing UX.

Screenshots

When the button is inactive or closed:
closed

when the button is active or opened:
opened

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow [best practices][best_practices].
  • My code follows the established code style of the repository.
  • [] I added or updated tests for the changes I made (if applicable).
  • [] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

@SisiVero SisiVero requested review from a team as code owners October 8, 2024 15:06
@SisiVero SisiVero requested review from TimidRobot, possumbilities, MuluhGodson and dhruvkb and removed request for a team October 8, 2024 15:07
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit 5340e03
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/6705848aa4a2670008f1ddbb
😎 Deploy Preview https://deploy-preview-145--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/js/vocabulary.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Change button text when active or inactive.
2 participants