-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate skill label generation #86
Comments
I think it makes sense to build the skills based on I wonder if we could also encode branch protection in |
@dhruvkb Shall i implement this one. |
Yeah @Cronus1007, please do! But let's start with a plan on how the |
@dhruvkb Here what I am planning that first of all let us make a request on |
The skill label generation has to work on all CC repositories, not just the first one. Also why just the first three technologies and not all of them? Another important consideration is regarding language and framework/library. For example, someone who is quite familiar with JavaScript might still experience some problems if the issue is very Vue-oriented... so the frameworks have to be factored in when building labels. |
@dhruvkb Let me a build a seperate folder for this and initialize this project by eod or should I build a local repo. |
Any opinoin regarding this? |
@Cronus1007 you can create a test organisation on GitHub and use your own personal access token to test your scripts on it. |
@dhruvkb Since I am much comfortable with javascript so shall I make a node app rather than django app. |
I have made a test repo depicting the behaviour . |
@dhruvkb I am able to write |
The package you are using for the API call might be paginated. Please open a draft PR so that we can take a closer look at your code. |
Because this repository is already written in Python, I don't think I'm going to approve any code written in JavaScript. Having 90% of the codebase written in Python and a single script written in JavaScript creates additional maintenance burden and complexity in the repository. @Cronus1007 if you'd like to attempt to work on this in Python, I'm sure our community on GitHub and Slack would be very willing to help you! Otherwise, unless @dhruvkb has opinions on why we should allow JavaScript, you're welcome to keep working on other issues. Thank you. |
@zackkrida I agree with this part but in my #122 PR it is just a roght idea of the approach. But while merging I will make the transition from |
@zackkrida @dhruvkb I am done with the #122 PR to automate the process and generating the required |
Problem
Skill labels need to be manually set up in
skills.json
. Thiscc-metadata.yml
under thetechnologies
key in each repoDescription
The technologies key could be expanded to a more verbose structure to describe languages, libraries and frameworks and then used to eliminate the need for
skills.json
entirely. This presents benefits such asAlternatives
The improvements to
.cc-metadata.yml
can be a good-to-have part of the feature if there isn't a consensus to proceed with that. But the automation of skill labels is still beneficial. Also it does not have to be binary, a combination of.cc-metadata.yml
andskills.json
would also be a fine solution.Implementation
The text was updated successfully, but these errors were encountered: