Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template error editing field mappings where Google Map field is present #1416

Open
c-simons opened this issue Mar 18, 2024 · 1 comment
Open
Labels

Comments

@c-simons
Copy link

c-simons commented Mar 18, 2024

Description

After updating a website to version Craft 4.4, I have since not been able to update the field mapping settings for a feed that is updating an section containing a Google Map field.

  • Outside of dev/debug mode, the save action fails silently with changes made to the field mappings being discarded without feedback.

  • On development I receive a twig runtime error:

    • Key "handle" for array with keys "label, width, position" does not exist.
    • ./vendor/craftcms/feed-me/src/templates/_includes/fields/google-maps.html:58
    • originally loaded @ ./vendor/craftcms/feed-me/src/fields/GoogleMaps.php:58
    • loading the 'google-maps-before-4-3' template restores service
    • Blame trace leads us to a change made in 5.1.0
// ./vendor/craftcms/feed-me/src/fields/GoogleMaps.php

// If earlier than Google Maps v4.3, return old version of the template
if ($pre43) {
    return 'feed-me/_includes/fields/google-maps-before-4-3';
}

// By default, return the modern version of the template
return 'feed-me/_includes/fields/google-maps';

Fields affected:

  • 'addresses'
    • Super table with nested Google Map
  • 'address'
    • Google map field

Steps to reproduce

  1. On development env only (see description for silent fail outside of dev mode)
  2. Navigate to feed field mappings for feed
  3. Observe error

Additional info

  • Craft version: 4.8.3
  • PHP version: 8.1.14
  • Database driver & version: MySQL 5.7
  • Plugins & versions:
    • Craft 4.8.3
    • Google Maps 4.4.0
    • Feed Me 5.4.0
    • Super Table 3.0.12
@c-simons c-simons added the bug label Mar 18, 2024
@i-just
Copy link
Contributor

i-just commented May 16, 2024

Hi, thanks for reaching out! I can’t replicate this issue. Are you still encountering this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants