Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider dropping venv iteration #40

Open
jonapich opened this issue May 19, 2023 · 0 comments
Open

consider dropping venv iteration #40

jonapich opened this issue May 19, 2023 · 0 comments

Comments

@jonapich
Copy link
Member

coveo-stew was designed to be able to prepare multiple venvs and then test them in one go:

# create 3 envs
poetry env use python3.9
poetry env use python3.10
poetry env use python3.11

# test them all
stew ci

I can only think of downsides:
- execution takes Nx the time (as much venvs you got)
- user doesn't always notice that stew ci runs twice
- when projects evolve and change their python constraint, old environments are used and fail
- the user isn't aware of this functionality and only learns it when a problem occurs

Anyway, most CI wants to run supported versions in parallel, so they wouldn't use this.

We should instead just test the active one (i.e.: poetry env list displays which one is current).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant