From af1c3ac1796bdfd534b5d037f3a42e23aa3ab225 Mon Sep 17 00:00:00 2001 From: Olivier Lamothe Date: Wed, 25 Oct 2023 16:00:12 -0400 Subject: [PATCH] feat(cli): node 20.9.0 lts (#1337) https://coveord.atlassian.net/browse/CDX-1495 --- .github/actions/e2e-run/action.yml | 2 +- .nvmrc | 2 +- packages/cli/core/package.json | 2 +- packages/cli/core/src/commands/ui/create/angular.ts | 2 +- packages/cli/core/src/commands/ui/create/react.ts | 2 +- packages/cli/core/src/commands/ui/create/vue.ts | 2 +- packages/cli/core/src/lib/atomic/createAtomicProject.ts | 2 +- packages/cli/source/package.json | 2 +- packages/ui/cra-template/package.json | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/actions/e2e-run/action.yml b/.github/actions/e2e-run/action.yml index 8262b96b08..95cc1de9a0 100644 --- a/.github/actions/e2e-run/action.yml +++ b/.github/actions/e2e-run/action.yml @@ -39,7 +39,7 @@ runs: - uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3 with: cache: 'npm' - node-version: ${{inputs.node}} + node-version-file: '.nvmrc' - uses: actions/setup-python@57ded4d7d5e986d7296eab16560982c6dd7c923b # v4 with: cache: 'pip' diff --git a/.nvmrc b/.nvmrc index aad5ebe18d..43bff1f8cf 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -20.8.0 \ No newline at end of file +20.9.0 \ No newline at end of file diff --git a/packages/cli/core/package.json b/packages/cli/core/package.json index dec581f0c5..b206eafa71 100644 --- a/packages/cli/core/package.json +++ b/packages/cli/core/package.json @@ -4,7 +4,7 @@ "author": "Coveo", "description": "Coveo CLI", "engines": { - "node": "^18.18.1 || ^20.8.1" + "node": "^18.18.1 || ^20.9.0" }, "dependencies": { "@amplitude/analytics-node": "^1.3.3", diff --git a/packages/cli/core/src/commands/ui/create/angular.ts b/packages/cli/core/src/commands/ui/create/angular.ts index 220fa13fbf..86a702cc0b 100644 --- a/packages/cli/core/src/commands/ui/create/angular.ts +++ b/packages/cli/core/src/commands/ui/create/angular.ts @@ -29,7 +29,7 @@ export default class Angular extends CLICommand { * Requirements Based on https://angular.io/guide/setup-local * and https://www.npmjs.com/package/@angular/cli package.json engines section. */ - public static requiredNodeVersion = '^18.18.1 || ^20.8.1'; + public static requiredNodeVersion = '^18.18.1 || ^20.9.0'; public static requiredNpmVersion = '^9.8.1 || ^10.1.0'; public static requiredNgVersion = '^15.0.0'; diff --git a/packages/cli/core/src/commands/ui/create/react.ts b/packages/cli/core/src/commands/ui/create/react.ts index 09d874d749..28e05c21b9 100644 --- a/packages/cli/core/src/commands/ui/create/react.ts +++ b/packages/cli/core/src/commands/ui/create/react.ts @@ -38,7 +38,7 @@ export default class React extends CLICommand { * "You’ll need to have Node 18.18.1 or later version on your local development machine" * https://github.com/facebook/create-react-app#creating-an-app */ - public static requiredNodeVersion = '^18.18.1 || ^20.8.1'; + public static requiredNodeVersion = '^18.18.1 || ^20.9.0'; public static description = 'Create a Coveo Headless-powered search page with the React web framework. See and .'; diff --git a/packages/cli/core/src/commands/ui/create/vue.ts b/packages/cli/core/src/commands/ui/create/vue.ts index a45d2bfde7..706f0ceeab 100644 --- a/packages/cli/core/src/commands/ui/create/vue.ts +++ b/packages/cli/core/src/commands/ui/create/vue.ts @@ -34,7 +34,7 @@ export default class Vue extends CLICommand { * @see https://cli.vuejs.org/guide/installation.html for current requirements. * @see https://github.com/vuejs/vue-cli/blob/dev/CHANGELOG.md for upcoming requirements. */ - public static requiredNodeVersion = '^18.18.1 || ^20.8.1'; + public static requiredNodeVersion = '^18.18.1 || ^20.9.0'; public static description = 'Create a Coveo Headless-powered search page with the Vue3 and Vite. See and .'; diff --git a/packages/cli/core/src/lib/atomic/createAtomicProject.ts b/packages/cli/core/src/lib/atomic/createAtomicProject.ts index 336a4ce327..237b344783 100644 --- a/packages/cli/core/src/lib/atomic/createAtomicProject.ts +++ b/packages/cli/core/src/lib/atomic/createAtomicProject.ts @@ -34,7 +34,7 @@ export const atomicAppInitializerPackage = '@coveo/create-atomic'; export const atomicLibInitializerPackage = '@coveo/create-atomic-component-project'; -const supportedNodeVersions = '^18.18.1 || ^20.8.1'; +const supportedNodeVersions = '^18.18.1 || ^20.9.0'; const transformPackageNameToNpmInitializer = (packageName: string) => packageName.replace('/create-', '/'); diff --git a/packages/cli/source/package.json b/packages/cli/source/package.json index 0f656f3c6a..0c421cd602 100644 --- a/packages/cli/source/package.json +++ b/packages/cli/source/package.json @@ -74,7 +74,7 @@ "prepublishOnly": "rimraf lib && npm run build && oclif manifest" }, "engines": { - "node": "^18.18.1 || ^20.8.1" + "node": "^18.18.1 || ^20.9.0" }, "bugs": "https://github.com/coveo/cli/issues", "keywords": [ diff --git a/packages/ui/cra-template/package.json b/packages/ui/cra-template/package.json index 98b49085de..a177280c7c 100644 --- a/packages/ui/cra-template/package.json +++ b/packages/ui/cra-template/package.json @@ -20,7 +20,7 @@ }, "license": "Apache-2.0", "engines": { - "node": "^18.18.1 || ^20.8.1" + "node": "^18.18.1 || ^20.9.0" }, "files": [ "template",