From 91e26c7facacc38d16fb6c6997d23eff438f8a29 Mon Sep 17 00:00:00 2001 From: Olivier Lamothe Date: Thu, 12 Oct 2023 16:46:01 -0400 Subject: [PATCH] feat(cli): change node support to 18.18.1 https://coveord.atlassian.net/browse/CDX-1407 --- packages/cli/core/package.json | 2 +- packages/cli/core/src/commands/ui/create/angular.ts | 4 ++-- packages/cli/core/src/commands/ui/create/react.ts | 2 +- packages/cli/core/src/commands/ui/create/vue.ts | 2 +- packages/cli/core/src/lib/atomic/createAtomicProject.ts | 2 +- packages/cli/source/package.json | 2 +- packages/ui/cra-template/package.json | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/cli/core/package.json b/packages/cli/core/package.json index 382717d3ee..5107908894 100644 --- a/packages/cli/core/package.json +++ b/packages/cli/core/package.json @@ -4,7 +4,7 @@ "author": "Coveo", "description": "Coveo CLI", "engines": { - "node": "^16.13.0 || ^18.12.0" + "node": ">=18.18.1" }, "dependencies": { "@amplitude/analytics-node": "^1.3.3", diff --git a/packages/cli/core/src/commands/ui/create/angular.ts b/packages/cli/core/src/commands/ui/create/angular.ts index 0657804c33..c1eb4b5e3e 100644 --- a/packages/cli/core/src/commands/ui/create/angular.ts +++ b/packages/cli/core/src/commands/ui/create/angular.ts @@ -29,8 +29,8 @@ export default class Angular extends CLICommand { * Requirements Based on https://angular.io/guide/setup-local * and https://www.npmjs.com/package/@angular/cli package.json engines section. */ - public static requiredNodeVersion = '^12.14.1 || >=14.0.0'; - public static requiredNpmVersion = '^6.11.0 || ^7.5.6 || >=8.0.0'; + public static requiredNodeVersion = '>=18.18.1'; + public static requiredNpmVersion = '>=9.8.1'; public static requiredNgVersion = '^15.0.0'; public static description = diff --git a/packages/cli/core/src/commands/ui/create/react.ts b/packages/cli/core/src/commands/ui/create/react.ts index d2032a45d1..9a251fa594 100644 --- a/packages/cli/core/src/commands/ui/create/react.ts +++ b/packages/cli/core/src/commands/ui/create/react.ts @@ -38,7 +38,7 @@ export default class React extends CLICommand { * "You’ll need to have Node 14.0.0 or later version on your local development machine" * https://github.com/facebook/create-react-app#creating-an-app */ - public static requiredNodeVersion = '>=14.0.0'; + public static requiredNodeVersion = '>=18.1.1'; public static description = 'Create a Coveo Headless-powered search page with the React web framework. See and .'; diff --git a/packages/cli/core/src/commands/ui/create/vue.ts b/packages/cli/core/src/commands/ui/create/vue.ts index 2185ae1273..5ab2510a3d 100644 --- a/packages/cli/core/src/commands/ui/create/vue.ts +++ b/packages/cli/core/src/commands/ui/create/vue.ts @@ -34,7 +34,7 @@ export default class Vue extends CLICommand { * @see https://cli.vuejs.org/guide/installation.html for current requirements. * @see https://github.com/vuejs/vue-cli/blob/dev/CHANGELOG.md for upcoming requirements. */ - public static requiredNodeVersion = '>=16'; + public static requiredNodeVersion = '>=18.1.1'; public static description = 'Create a Coveo Headless-powered search page with the Vue3 and Vite. See and .'; diff --git a/packages/cli/core/src/lib/atomic/createAtomicProject.ts b/packages/cli/core/src/lib/atomic/createAtomicProject.ts index b2a5f5ca42..ccd2b5c80d 100644 --- a/packages/cli/core/src/lib/atomic/createAtomicProject.ts +++ b/packages/cli/core/src/lib/atomic/createAtomicProject.ts @@ -34,7 +34,7 @@ export const atomicAppInitializerPackage = '@coveo/create-atomic'; export const atomicLibInitializerPackage = '@coveo/create-atomic-component-project'; -const supportedNodeVersions = '16.x || 18.x'; +const supportedNodeVersions = '>=18.1.1'; const transformPackageNameToNpmInitializer = (packageName: string) => packageName.replace('/create-', '/'); diff --git a/packages/cli/source/package.json b/packages/cli/source/package.json index ce8a3c79fa..cecb00ffaf 100644 --- a/packages/cli/source/package.json +++ b/packages/cli/source/package.json @@ -74,7 +74,7 @@ "prepublishOnly": "rimraf lib && npm run build && oclif manifest" }, "engines": { - "node": "^16.13.0 || ^18.12.0" + "node": ">=18.18.1" }, "bugs": "https://github.com/coveo/cli/issues", "keywords": [ diff --git a/packages/ui/cra-template/package.json b/packages/ui/cra-template/package.json index 397399386e..d64978dad3 100644 --- a/packages/ui/cra-template/package.json +++ b/packages/ui/cra-template/package.json @@ -20,7 +20,7 @@ }, "license": "Apache-2.0", "engines": { - "node": "^16.13.0 || ^18.12.0" + "node": ">=18.18.1" }, "files": [ "template",