Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Explicit Embedded Mode Support #21

Open
jimhooker2002 opened this issue Mar 26, 2017 · 0 comments
Open

RFC: Explicit Embedded Mode Support #21

jimhooker2002 opened this issue Mar 26, 2017 · 0 comments

Comments

@jimhooker2002
Copy link
Contributor

Just wanted to contribute the following for discussion. As argued in #16 (see my comments on the ticket towards the bottom) I'd love to see "embedded" mode, explicitly supported as part of this project.

I sketched out the following jimhooker2002/CouchbaseMock@master...embedded-support-proto

I'd love to get some comments/thoughts on the idea. Is it worth me spending a bit of time sketching out the rest of that class (production quality/tests/documentation etc)? Philosophically, is it clear what I'm trying to do here, and do you guys agree it's a good idea? Of course, if you don't agree that this is useful, then there's no point me spending a bunch of time on it.

As mentioned in the comments of the diff - the existing client code that we have to talk with HarikiriMonitor over a socket/HTTP makes perfect sense when running in a seperate process. But, when running in embedded mode (same process as test code) it's a nicer experience to just do "regular Java stuff" with the CouchbaseMock object itself - no network/REST/socket interaction, and the usage of Java types as opposed to the raw JSON.

All the best,

Jim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant