Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why there is using a specific model with an abstract repository but not some abstract or base model? #57

Open
svnikolaev opened this issue Jan 18, 2023 · 1 comment

Comments

@svnikolaev
Copy link

Hello,
Can you tell me please why the specific model model.Product used here with the abstract repository AbstractRepository but not some abstract or base model?

code/src/allocation/adapters/repository.py:

def get(self, sku) -> model.Product:

def _add(self, product: model.Product):

def _get(self, sku) -> model.Product:

def _get_by_batchref(self, batchref) -> model.Product:

@hjwp
Copy link
Contributor

hjwp commented Sep 11, 2023

probably you could rename AbstractRepository to AbstractProductRepository. repositories are mean to be specific for one aggregate...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@hjwp @svnikolaev and others