Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deepdish for h5py #415

Closed
ejolly opened this issue May 8, 2023 · 2 comments
Closed

Drop deepdish for h5py #415

ejolly opened this issue May 8, 2023 · 2 comments
Labels

Comments

@ejolly
Copy link
Collaborator

ejolly commented May 8, 2023

Deepdish doesn't seem to be under development any more: uchicago-cs/deepdish#49 (comment)

It also fails for the latest version of numpy 1.24, due to enforced API deprecations. I've currently pinned us to numpy<1.24, but we should drop it as a dependency and switch over to h5py ASAP, which has long term support from the HDF5 team. But this will require a bit of rewriting for how we're saving and loading Brain_Data and Adjacency objects

@ljchang
Copy link
Member

ljchang commented Sep 28, 2023

@ejolly. Apologies for the delay. Seems like it is reading and writing data ok. I propose merging this and unpinning the old versions of numpy. thanks!

@ejolly
Copy link
Collaborator Author

ejolly commented Nov 9, 2023

Done in #416

@ejolly ejolly closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants