Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discount Total with Shipping #2503

Open
solverat opened this issue Jan 11, 2024 · 4 comments
Open

Discount Total with Shipping #2503

solverat opened this issue Jan 11, 2024 · 4 comments

Comments

@solverat
Copy link
Contributor

Q A
Bug report? not sure
Feature request? no
BC Break report? no
RFC? yes/no
  • Add a product with price of 200
  • Add voucher cart rule with action Discount Amount:

image

Total stays at 10 (Shipping costs):

image

Since I've selected Total in Apply On, I'm expecting a total of 0.

@dpfaffenbauer
Copy link
Member

@solverat might this be a priority issue? so the discount is calculated before the shipping is? what happens if you click update cart again?

@solverat
Copy link
Contributor Author

what happens if you click update cart again?

Unfortunately, it stays the same.

@dpfaffenbauer
Copy link
Member

Fortunately ;) that is good news, so we know nothing shady is going on. I have to debug this to figure it out

@dpfaffenbauer
Copy link
Member

@solverat I took some time, but I debugged it today. The "Apply On" actually doesn't work anymore since we introduced applying the discounts to the items with item ajdustments. this is intentional for vat reasons. if we have discounts, we have apply them to the items to re-calculate the vat. If we apply more then the cart is worth, we only use as much as possible from the subtotal (subtotal being the total of all items). other adjustments like shipping are not affected, since this only get's applied to items.

My suggested solution: remove the "Apply On" option since it doesn't make sense and doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants