Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-bot/Dockerfile: Move to Fedora 39 #184

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

c4rt0
Copy link
Member

@c4rt0 c4rt0 commented Feb 12, 2024

@c4rt0 c4rt0 changed the title Dockerfile: Move to Fedora 39 config-bot/Dockerfile: Move to Fedora 39 Feb 12, 2024
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Ideally we'd actually test this before merging, but in the past it's been quite safe. When merging this (and other PRs like this one that update a service), watch the rebuild and deployment in OpenShift to sanity-check it comes up fine.

@c4rt0
Copy link
Member Author

c4rt0 commented Feb 13, 2024

When merging this (and other PRs like this one that update a service), watch the rebuild and deployment in OpenShift to sanity-check it comes up fine.

Will keep that in mind, thanks for the review!

@c4rt0
Copy link
Member Author

c4rt0 commented Feb 13, 2024

I found this on Openshift (no errors were recorded):

STEP 7/7: LABEL
...
 "io.openshift.build.commit.message"="Merge pull request #186 from c4rt0/moveToFedora39"
  "io.openshift.build.commit.ref"="main" "io.openshift.build.name"="config-bot-39"  

I guess that's safe.

@c4rt0 c4rt0 merged commit 4ce5190 into coreos:main Feb 13, 2024
1 check passed
@c4rt0 c4rt0 deleted the moveOntoF39 branch February 13, 2024 17:08
@jlebon
Copy link
Member

jlebon commented Feb 13, 2024

Yeah, that's the image build. You'll want to also check that the new pod comes up and is happy (oc get pods).

Also, this would happen after that PR is merged. Those logs are from when #186 was merged it looks like. (But a good time to also check that the importer is also up and running fine.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants