fix: correctly retrieve the last partition of the installation disk #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grepping /proc/partitions the way we're doing doesn't account for devices with more numbers according to our grep command. Devices like nvme0n1 would just return "0" as the last partition but that's wrong as what gets executed is: grep -c nvme0n1[0-9] /proc/partitions which just returns 0 but it's obviously not the last partition. Fix the above by using the sys filesystem as it provides better heiraical nature of paritions within a drive without accounting for its string format. Signed-off-by: Antonio Murdaca <[email protected]>
|
/test-9 |
miabbott
approved these changes
Aug 31, 2023
|
LGTM 👍 |
|
tests are stuck because of the kernel bug for qemu, we're testing this manually |
|
Manually restarting the vm with
also, manually tweaking virt-install to use an nvme drive works as expected again
I'll wait for Mario to confirm it works on real hardware and we should be good |
|
The generated iso has been tested in Onlogic HX401 bare-metal device. After tweaking disk device name from /dev/vda /dev/nvme0n1 the root file system has grown to the proper size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grepping /proc/partitions the way we're doing doesn't account for devices with more numbers according to our grep command. Devices like nvme0n1 would just return "0" as the last partition but that's wrong as what gets executed is:
grep -c nvme0n1[0-9] /proc/partitions
which just returns 0 but it's obviously not the last partition. Fix the above by using the sys filesystem as it provides better heiraical nature of paritions within a drive without accounting for its string format.