way to enable/disable individual components of messages #15
Comments
|
Possibility: use a subpackage of scripts/other bits like udev rules to run that generate the generic motds, which can be installed optionally for the basic hardcoded messages |
rfairley
changed the title
rfairley
pushed a commit
to rfairley/console-login-helper-messages
that referenced
this issue
Apr 20, 2020
Split out `if_snippets_gen` from the `issuegen` script. This makes the udev rule `90-console-login-helper-messages-if_snippets_gen.rules` responsible only for writing snippets with information about network interfaces to the runtime issue snippets directory (`/run/console-login-helper-messages/issue.d`) read by `issuegen` to generate the final `/run/console-login-helper-messages/40_console-login-helper-messages.issue` file read by the serial terminal (agetty). This is beneficial as it helps avoid situations where multiple invocations of `issuegen` are executed concurrently (leading to bugs like coreos#35). This is also a first step towards making the shown information more configurable (coreos#15). Also preparation for coreos#7, which will involve making the `issuegen` script more configurable by accepting a `--legacy` flag (coreos#7 (comment)), by reducing the number places in the code that the `issuegen` function is called (so less downstream patching to pass in a `--legacy` flag required). Add `console-login-helper-messages.path`, so that `issuegen` is run whenever snippets are written to `/run/console-login-helper-messages/issue.d`. This should be the main way of triggering a run of `issuegen` (first trigger the path, which starts the service, which will run `issuegen`). The only other time the `issuegen` service is invoked is on boot (if the unit is enabled). Note, enablement of the path unit is required upon installation.
rfairley
pushed a commit
to rfairley/console-login-helper-messages
that referenced
this issue
Apr 20, 2020
Split out `if_snippets_gen` from the `issuegen` script. This makes the udev rule `90-console-login-helper-messages-if_snippets_gen.rules` responsible only for writing snippets with information about network interfaces to the runtime issue snippets directory (`/run/console-login-helper-messages/issue.d`) read by `issuegen` to generate the final `/run/console-login-helper-messages/40_console-login-helper-messages.issue` file read by the serial terminal (agetty). This is beneficial as it helps avoid situations where multiple invocations of `issuegen` are executed concurrently (leading to bugs like coreos#35). This is also a first step towards making the shown information more configurable (coreos#15). Preparation also for coreos#7, reducing the number of places in the code that `issuegen` is called directly, reducing potential downstream patching needed to pass in a `--legacy` option to the script (coreos#7 (comment)). Add `console-login-helper-messages.path`, so that `issuegen` is run whenever snippets are written to `/run/console-login-helper-messages/issue.d`. This should be the main way of triggering a run of `issuegen` (first trigger the path, which starts the service, which will run `issuegen`). The only other time the `issuegen` service is invoked is on boot (if the unit is enabled). Note, enablement of the path unit is required upon installation.
This was referenced Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Users should be able to turn on/off showing the components listed under https://github.com/rfairley/console-login-helper-messages#usage. Discuss how this might happen.
Possibly just split each component into its own individual unit and have it generate to motd or issue or both.
The text was updated successfully, but these errors were encountered: