Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Repository maintenance #4

Open
2 of 10 tasks
jptosso opened this issue Jul 3, 2024 · 5 comments
Open
2 of 10 tasks

Repository maintenance #4

jptosso opened this issue Jul 3, 2024 · 5 comments

Comments

@s3rj1k
Copy link
Contributor

s3rj1k commented Jul 3, 2024

We had a quick talk regarding CI before with @fzipi.
I can take this, but needs a bit more discussion on what exactly we want to check there.

@jptosso
Copy link
Member Author

jptosso commented Jul 3, 2024

@s3rj1k it's up for discussion, but I think we should cover tests and run the benchmark making sure that all bechmarks are run.
Also, I think we should deprecate v2 benchmarks, as it is not supported anymore and the comparison is irrelevant

@s3rj1k
Copy link
Contributor

s3rj1k commented Jul 3, 2024

deprecate v2 benchmarks

we can add that it's not supported but I would like to keep them as long as possible for reference, this reference has real value for project support because of huge performance increase that can be verified locally

@fzipi
Copy link
Member

fzipi commented Jul 3, 2024

Found this one that might help: https://github.com/marketplace/actions/continuous-benchmark

@s3rj1k
Copy link
Contributor

s3rj1k commented Jul 3, 2024

We actually don't have go benchmarks there, documentation is wrong about that, we run go application that computes time between stages and produces CSV.

I've done quick docker magic to showcase how it works, just in case we want a demo:

git clone -b docker https://github.com/s3rj1k/coraza-benchmark.git 
cd coraza-benchmark
docker run --rm -v $(pwd)/tests:/opt/coraza-benchmark/tests -v $(pwd)/waf.rules:/opt/coraza-benchmark/waf.rules docker.io/s3rj1k/coraza-benchmark -rules=/opt/coraza-benchmark/waf.rules

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants