Skip to content

Commit

Permalink
commit task after group list removal
Browse files Browse the repository at this point in the history
  • Loading branch information
colinthomas-z80 committed Nov 18, 2024
1 parent dff68b7 commit 78cba11
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion taskvine/src/manager/vine_manager.c
Original file line number Diff line number Diff line change
Expand Up @@ -2940,13 +2940,13 @@ static vine_result_code_t commit_task_group_to_worker(struct vine_manager *q, st
int counter = 0;
do {

result = commit_task_to_worker(q, w, t);
if (counter && (result == VINE_SUCCESS)) {
int t_idx = priority_queue_find_idx(q->ready_tasks, t);
priority_queue_remove(q->ready_tasks, t_idx);
// decrement refcount
vine_task_delete(t);
}
result = commit_task_to_worker(q, w, t);
counter++;
} while ((l && (t = list_pop_head(l))));

Expand Down
5 changes: 0 additions & 5 deletions taskvine/src/worker/vine_sandbox.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,11 @@ vine_cache_status_t vine_sandbox_ensure(struct vine_process *p, struct vine_cach
struct vine_process *lp;
uint64_t task_id;
int found_file = 0;
debug(D_VINE, "iterate proc list");
debug(D_VINE, "procs table %p", procs_table);
ITABLE_ITERATE(procs_table, task_id, lp)
{
debug(D_VINE, "index proc");
struct vine_mount *lm;
LIST_ITERATE(lp->task->output_mounts, lm)
{
debug(D_VINE, "comparing %s and %s", lm->file->cached_name, m->file->cached_name);
if (strcmp(lm->file->cached_name, m->file->cached_name) == 0) {
found_file = 1;
break;
Expand All @@ -75,7 +71,6 @@ vine_cache_status_t vine_sandbox_ensure(struct vine_process *p, struct vine_cach
}
}
if (found_file) {
debug(D_VINE, "Found file in process queue");
processing++;
break;
}
Expand Down

0 comments on commit 78cba11

Please sign in to comment.