Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Import transfer: movements & transfer with the same created_at #727

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

franpb14
Copy link
Collaborator

@franpb14 franpb14 commented Jan 6, 2024

Changes

  • now when te movements are created they use the same created at as the transfer

Note: If we didn't want to touch the rest of the app and only make this change in the import, we could use transfer.movements.update_all(created_at: transfer.created_at) in process_row after the transfer save. However, I believe it makes more sense as I placed it, to ensure consistency between transfer and movements at all times

@sseerrggii
Copy link
Contributor

Tested on staging ✔️
Works fine, thanks @franpb14

@markets markets merged commit 615e4d1 into develop Jan 7, 2024
3 of 4 checks passed
@markets markets deleted the fix-transfer-movements branch January 7, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants