Merge pull request #26 from cookpad/buffered-output

BufferedOutput must be InstantiatableOutput
cookpad · May 1, 2020 · 58c3377 · 58c3377
2 parents bb0b14b + fb8523f
commit 58c3377
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Sources/Puree/Output/BufferedOutput.swift b/Sources/Puree/Output/BufferedOutput.swift
@@ -1,10 +1,10 @@
 import Foundation
 
-open class BufferedOutput: Output {
+open class BufferedOutput: InstantiatableOutput {
     private let dateProvider: DateProvider = DefaultDateProvider()
     internal let readWriteQueue = DispatchQueue(label: "com.cookpad.Puree.Logger.BufferedOutput", qos: .background)
 
-    public init(logStore: LogStore, tagPattern: TagPattern) {
+    required public init(logStore: LogStore, tagPattern: TagPattern, options: OutputOptions? = nil) {
         self.logStore = logStore
         self.tagPattern = tagPattern
     }

diff --git a/Tests/PureeTests/LoggerTests.swift b/Tests/PureeTests/LoggerTests.swift
@@ -57,7 +57,7 @@ class LoggerTests: XCTestCase {
         XCTAssertEqual(buffer.logs(for: "pv").count, 1)
 
         let log = buffer.logs(for: "pv").first!
-        guard let userInfo = try? JSONSerialization.jsonObject(with: log.userData!, options: []) as! [String: Any] else {
+        guard let userInfo = try? (JSONSerialization.jsonObject(with: log.userData!, options: []) as! [String: Any]) else {
             return XCTFail("userInfo could not decoded")
         }
         XCTAssertEqual(userInfo["page_name"] as! String, "Top")
@@ -191,7 +191,7 @@ class LoggerTests: XCTestCase {
 
         for index in testIndices {
             let found = logs.contains { log -> Bool in
-                guard let userInfo = try? JSONSerialization.jsonObject(with: log.userData!, options: []) as! [String: Any] else {
+                guard let userInfo = try? JSONSerialization.jsonObject(with: log.userData!, options: []) as? [String: Any] else {
                     XCTFail("userInfo could not decoded")
                     return false
                 }