Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin request - Avatars in roster and MUC participant list #10

Open
muppeth opened this issue Aug 3, 2019 · 8 comments
Open

Plugin request - Avatars in roster and MUC participant list #10

muppeth opened this issue Aug 3, 2019 · 8 comments
Labels
enhancement New feature or request

Comments

@muppeth
Copy link

muppeth commented Aug 3, 2019

I see there is such feature on Pade, I was wondering, if it would be easy for you @deleolajide to port it to converse. I love looks of Pade, including the default when no avatar is given (there was also a random color assigned to them right?).

@deleolajide
Copy link
Member

I was wondering, if it would be easy for you @deleolajide to port it to converse.

The Pàdé look was created out of an experiment on this converse issue. It is mostly a direct hack to the converse.js code and default templates. I should either upstream it back to Converse with the accompanying settings or re-implement as a plugin and override the templates, but I am very pre-occupied with other things right now.

I may revisit it when I have to tackle the imminent upgrading of Pàdé to Converse 5.

@muppeth
Copy link
Author

muppeth commented Aug 6, 2019

I see. It would explain why i couldnt find it in the plugin section of pade. Is there a place (excuse me if its obvious and i missed it) where you have the source code of the converse. As far as I can see there is only dist builds on Pade's repo.

Edit
I guess this is it: https://github.com/deleolajide/converse.js (if there are specific commits to point me to would be amazing)

@deleolajide
Copy link
Member

Sorry, I am old school. I work directly with HTML, JS and CSS files. That is my source code :-)
My hacking can be identified with the // BAO comments

@muppeth
Copy link
Author

muppeth commented Aug 7, 2019

Damn..... Taht would explain why I couldnt find it anywhere in commit tree. So you hacked directly on dist files or you have somewhere templates/css/js files you touched.
EDIT
Following now dist files looking at the BAO comments. WIll take some time but should manage to migrate it to my fork.

@muppeth
Copy link
Author

muppeth commented Aug 7, 2019

BTW is there any Pade instance with public signup so that one could check all the hardcoded features. checking the commented changes, I see there is quite some of them (reactions, drag and drop file upload etc).

@deleolajide
Copy link
Member

deleolajide commented Aug 7, 2019

http://pade.chat runs Pàdé in web and pwa mode. Please note that pwa mode is not yet optimised, but it works. You can create an account and play with most features as the openfire server has some of the required plugins installed.

To get the best results, use the chrome extension and point at pade.chat:443 as server and pade.chat as domain.

@deleolajide
Copy link
Member

I guess this is it: https://github.com/deleolajide/converse.js (if there are specific commits to point me to would be amazing)

No. This - https://github.com/igniterealtime/Pade/blob/master/extension/inverse/dist/converse.js

@muppeth
Copy link
Author

muppeth commented Aug 8, 2019

http://pade.chat runs Pàdé in web and pwa mode.
Thanks. Will do

No. This - https://github.com/igniterealtime/Pade/blob/master/extension/inverse/dist/converse.js
Yeah I figured. But was hoping you have somewhere the sources before they were build (easier to check which exactly template or css file was touched.
But I guess you hacked directly on dist files so will need to sieve throurgh.

Thanls for all the info. I made account on pade.chat and damn this is packed with awesome features. You should definitely do it new school and use git so its easier for leachers like me to get all the good stuff :P

@Echolon Echolon added the enhancement New feature or request label Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants