Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested multiplier bugs #56

Open
LiborSitek opened this issue Nov 11, 2020 · 2 comments
Open

Nested multiplier bugs #56

LiborSitek opened this issue Nov 11, 2020 · 2 comments

Comments

@LiborSitek
Copy link

Hi, I use nested multiplier in another multiplier, where both multipliers (inner and outer) have been set the copy number to 1 (default) and I found 2 bugs:

  • The nested (inner) multiplier has container containing inputs with some defaultValues set by BaseControl::setDefaultValue(). However, when I add a new copy by multiplier submit create button, the inputs of the new copy does not have its default values filled (only the first default copy does have)

  • When I add a new copy of the outer multiplier by its submit create button, the inner multiplier of the new outer multiplier copy does not have created its default copy (like the copy number being ignored), however the first default copy of the outer multiplier does have its outer multiplier with its default copy created

@Kocicak
Copy link
Contributor

Kocicak commented Dec 2, 2020

I believe that pull request #59 fixes both of the problems.

@Stancek
Copy link

Stancek commented Apr 4, 2023

I believe that pull request #59 fixes both of the problems.

Correct

f3l1x pushed a commit that referenced this issue Feb 19, 2024
Pressing “Create” inside a nested multiplier with fields with default values
did not work before 39725d3.
This has been reported in the first bullet point in
#56

The second bullet point is already covered by `testSendNested`
change introduced in the fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants