Run htpasswd from our build-container instead of registry:2 #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
registry:2 no longer contains htpasswd. Also don't use log_and_run ... >> $file because that will cause the command to be logged to $file. Signed-off-by: Miloslav Trmač <[email protected]>
|
@edsantiago is introducing this dependency on the environment surrounding system tests acceptable? |
|
It's fine. It concerns me that we can't rely on docker's own documentation, and I wonder what else they might break without notice, but it is perfectly fine with me to move the htpasswd dependency to something more reliable. |
|
Yes, distribution/distribution-library-image#106 . It seems they didn’t want to keep updating the container for Merging now to unblock CI. Thanks! |
This was referenced Jul 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registry:2 no longer contains htpasswd.