Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing of query string parameters in API calls #220

Open
aik099 opened this issue Dec 31, 2024 · 1 comment · May be fixed by #222
Open

Support passing of query string parameters in API calls #220

aik099 opened this issue Dec 31, 2024 · 1 comment · May be fixed by #222
Milestone

Comments

@aik099
Copy link
Member

aik099 commented Dec 31, 2024

Some of the API calls support both request body parameters and query string parameters (e.g. https://developer.atlassian.com/cloud/jira/platform/rest/v2/api-group-issue-worklogs/#api-rest-api-2-issue-issueidorkey-worklog-id-put ).

Proposing to support the query_string/queryParams/_query key (or similar) in the $params/$options array for specifying these parameters.

The name must also be quite unique to avoid conflict with any of Request body parameters, that we any of current JIRA API calls (according to docs) can use.

@aik099
Copy link
Member Author

aik099 commented Jan 1, 2025

Having some special key in the $data parameter of the Api::api method looks a bit weird, but adding yet another optional parameter to the Api::api method (it already has 6 parameters) looks like an even worse decision to me.

// cc: @jpastoor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant