-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimizing M2 calls in parser #79
Comments
This is unlikely to be easy to implement, as it requires the parser to peek ahead and grab several rings at once. After a recent update to |
No, peaking ahead isn't necessary. Instead of getting them on the fly, wait til you finish parsing, then grab all of them at once. |
But the value returned by It is possible this can be done in a lazier fashion than it is right now, but I don't see a way to do so without significantly modifying the parser (both physically and philosophically). Perhaps we can reopen if it becomes a bottleneck in the future? |
Ohhhh, right. Yeah, that's true |
It is certainly worth looking into ways of minimizing the calls to
Both of these can be subverted by a malitious user, but at some point we need to trust them. I will reopen so that we can (potentially) add this in a future version. |
Excess calls to We should bump the priority on this. |
Suppose we wanted to retrieve two rings R and S from M2, as could happen during m2_parse(). What if we called M2 once with the input of (R,S)? Would this improve speed?
The text was updated successfully, but these errors were encountered: