Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing ideal tests using Macaulay2 1.23 ("did not throw an error") #239

Open
d-torrance opened this issue Apr 6, 2024 · 2 comments
Open

Comments

@d-torrance
Copy link

With Macaulay2 1.23, the m2r test suite fails with the following:

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-ideal.R:145:3'): ideal_(list("x+y x^2+y^2"), raw_chars = TRUE) errors ──
`ideal_(list("x+y x^2+y^2"), raw_chars = TRUE)` did not throw an error.
── Failure ('test-ideal.R:322:3'): ideal_.(list("x+y x^2+y^2"), raw_chars = TRUE) errors ──
`ideal_.(list("x+y x^2+y^2"), raw_chars = TRUE)` did not throw an error.

This is because x + y x^2+y^2 is now valid Macaulay2 code. In particular, it interprets the middle term y x^2 like sub(y, {x => x^2, y => y}), which evaluates to y, and so the entire expression evaluates to y^2 + x + y.

@dkahle
Copy link
Collaborator

dkahle commented Apr 9, 2024

Hey @d-torrance, thanks for the shout. Got a good reference where I can I read more about that change in M2?

@d-torrance
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants